Include all email data in 'extra' response #41
Conversation
riking
changed the title
This allows consumers to check whether or not Github has verified the emails. Manual selection by consumers is also available using the emails array in the `extra` response data. Additionally, a new 'display_email' field is added to `info`, which will always be the email displayed on your GitHub user page.
There was a problem hiding this comment.
This causes nil values to be changed into false.
|
Note, this is real urgent for Discourse, I am forking for now till its upstreamed. |
|
ping @mbleigh this is a pretty severe |
|
I think that a better solution for this might be to put the non-verified email in an A separate key containing an |
|
I agree with that, but it is a bit of a "good" breaking change. I think all the emails omniauth-github deals out should be verified. People should need to do extra work to get an unverified one. |
|
@SamSaffron I think we're saying the same thing. I'm saying that a boolean And therefore we should do the more secure thing. |
|
I'd still accept this if it were changed to put an unverified email in an |
|
Merged in #48 |
3 participants
This allows consumers to check whether or not Github has verified the emails, or use non-primary email addresses if they want. Important for consumers that need validated emails.
Additionally, a new 'display_email' field is added to
info, which will always be the email displayed on your GitHub user page.Fixes #36